Skip to content

Conversation

Copy link

Copilot AI commented Dec 11, 2025

The dump() function wrapper was missing a return type annotation, causing type checking ambiguity.

Changes

  • Added -> None return type annotation to dump() in gridappsd/json_extension.py

The function wraps json.dump(), which writes to a file object and returns None. The annotation now matches the standard library's signature.

def dump(
    data: Any,
    fo: TextIO,
    *,
    skipkeys=False,
    ensure_ascii=True,
    check_circular=True,
    allow_nan=True,
    indent=None,
    separators=None,
    default=None,
    sort_keys=False,
    **kw,
) -> None:  # Added
    _json.dump(...)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: craig8 <3979063+craig8@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on Pixi update PR Add missing return type annotation to json_extension.dump() Dec 12, 2025
Copilot AI requested a review from craig8 December 12, 2025 00:04
@craig8 craig8 marked this pull request as ready for review December 12, 2025 00:05
@craig8 craig8 merged commit 5a2fdc9 into pixi-update Dec 12, 2025
1 check passed
@craig8 craig8 deleted the copilot/sub-pr-193-again branch December 12, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants